Skip to content

Commit

Permalink
hide embedded notes option
Browse files Browse the repository at this point in the history
  • Loading branch information
@r888888888
r888888888 committed Sep 14, 2017
1 parent debf265 commit b361809
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions app/views/posts/partials/show/_edit.html.erb
View file
Expand Up @@ -34,13 +34,6 @@
<% end %>
</div>

<% unless post.is_note_locked? %>
<div class="input">
<%= f.label :has_embedded_notes, "Embed notes" %>
<%= f.check_box :has_embedded_notes %>
</div>
<% end %>
<% if CurrentUser.is_builder? %>
<div class="input">
<%= f.label :blank, "Lock" %>
Expand Down

3 comments on commit b361809

@BrokenEagle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that this was removed...? I frequently use this option myself.

@r888888888
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It honestly isn't used much at all. It's active on 4450 posts, which represents 1.3% of all posts with notes. For existing posts it'll continue to work (and I suppose you can update it via the API) but I don't think that usage rate warrants taking up screen real estate.

@BrokenEagle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to know. I already created a Javascript bookmarklet in topic #14437 that will continue to provide this functionality. Now that I know this is more of a permanent thing, I can go ahead and publish those functions in more permanent locations.

Please sign in to comment.