Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow click to toggle notes while in translation mode #1675

Closed
ToksT opened this issue May 25, 2013 · 2 comments
Closed

Allow click to toggle notes while in translation mode #1675

ToksT opened this issue May 25, 2013 · 2 comments

Comments

@ToksT
Copy link
Contributor

ToksT commented May 25, 2013

How about allowing to hide notes via clicks even while in translation mode? We could replace "click to insert note" with "drag to insert note", and disregard "dragging" < 10 px as "clicking".

Related: #1496

@Lightforger
Copy link
Contributor

Since the "ignore_click_until" hack was designed to stop hiding the notes on a "create note with a click" event, i just removed that, along with the "create note on a click" line.

Minor note;
A "click" event only changes to a "drag" event after dragging 3~4 pixels (default browser behavior), so when dragging between 4 & 9 pixels, it won't create a new note nor toggle the display.

@ToksT ToksT reopened this Jun 19, 2013
@ToksT ToksT closed this as completed Jun 19, 2013
Lightforger added a commit that referenced this issue Jun 19, 2013
bugged cross-browser
@Lightforger
Copy link
Contributor

Undid my fix;
On opera, the click event is not fired if you dragged more then a few pixels.
On firefox/chrome, the event does get fired as long as you are still over the image when releasing the mousebutton.

I'm not too sure how to properly implement this

@Lightforger Lightforger reopened this Jun 19, 2013
@ToksT ToksT closed this as completed in a1ab960 Aug 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants