Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous image links on new artist from Pixiv #3078

Closed
BrokenEagle opened this issue May 22, 2017 · 3 comments
Closed

Remove superfluous image links on new artist from Pixiv #3078

BrokenEagle opened this issue May 22, 2017 · 3 comments

Comments

@BrokenEagle
Copy link
Collaborator

From the Danbooru forums:

Provence said:
Regarding artists and Pixiv: We used to include a direct URL to an image.
Since a direct URL is added automatically when creating a new artist, is it ok that a direct URL is not added (since it seems superfluous and doesn't help anymore)?

BrokenEagle98 said:
Well, there used to be a reason, when the image URL was normalized (under the hood) to be of the format "http://img.pixiv.net/img/USERNAME/". However, it's now normalized as "http://www.pixiv.net/member.php?id=ID_NUMBER" which is already being added anyways. So yeah, there's no longer any reason to keep it around.
@r888888888
Copy link
Collaborator

Is it safe to just delete these from the database?

@evazion
Copy link
Member

evazion commented Jun 28, 2017

https://danbooru.donmai.us/artist_versions?search%5Bupdater_id%5D=13506

@RaisingK's bot still adds these http://img.pixiv.net/img/$username/ URLs. If they were removed it would likely try to add them all back.

IMO the bot should either add the Pixiv username to the Other Names field, or maybe add it as an http://www.pixiv.me/$username URL. Either way, adding http://img.pixiv.net/img/$username/ URLs is no longer necessary.

@RaisingK
Copy link
Collaborator

RaisingK commented Jul 9, 2017

I've taken that part out now.

evazion added a commit that referenced this issue Dec 27, 2018
@evazion
artists: improve prefilling of new artist form (#4028)
2170961 
* When creating an artist by clicking the '?' next to the artist tag in
  the tag list, prefill the new artist form by finding the artist's last
  upload and fetching its source data.

  Previously we filled the urls with the source of the artist's last
  upload, which was wrong because it was usually a direct image URL (#3078).

* Fix the other names field not escaping spaces within names to underscores.

* Fix the other names field being potentially prefilled with duplicate names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@r888888888 @RaisingK @evazion @BrokenEagle