Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 2048 Tumblr image links #4324

Closed
BrokenEagle opened this issue Mar 5, 2020 · 1 comment · Fixed by #4401
Closed

Add support for 2048 Tumblr image links #4324

BrokenEagle opened this issue Mar 5, 2020 · 1 comment · Fixed by #4401
Labels
Bug

Comments

@BrokenEagle
Copy link
Collaborator

Tumblr now has a 2048 image format, so this new size needs to be checked for and used when it is available. The following link can be used to test any updates.

https://kome-no-id.tumblr.com/image/190996209038
@BrokenEagle BrokenEagle added the Bug label Mar 6, 2020
@nonamethanks nonamethanks mentioned this issue Apr 1, 2020
Closed
@nonamethanks
Copy link
Member

As mentioned in issue #4380, we should go through all alt_sizes+original-size images returned by the API and compare their resolution, and pick the biggest one, rather than hardcode the biggest format. There's several cases where the original_size image is not the biggest available pic.

lllusion3469 added a commit to lllusion3469/danbooru that referenced this issue Apr 8, 2020
@lllusion3469
tumblr: pick biggest image based on resolution
65fb0cf 
photo[:alt_sizes] may contain a bigger image than
photo[:original_size]

fixes danbooru#4324
@lllusion3469 lllusion3469 mentioned this issue Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tumblr: pick biggest image based on resolution lllusion3469/danbooru
2 participants
@nonamethanks @BrokenEagle