Cannot view who favorited a post

[ToksT]

The list of users who favorited a post does not show up.

If this was an intentional change because you intend to add an option to make favorites private, then this feature should still be added back but should only display the names of those who don't have private favorites (similar to Pixiv).

[MyrMindservant]

This change indeed was intentional, see http://danbooru.donmai.us/forum_posts/84029

As for the list itself, I don't care either way but some people have requested it, or rather its return, so perhaps it can be readded once we have an option to make favorites private. Or maybe not, if it eats sizable chunk of server resources. It's up to Albert anyhow.

[r-ichi-e]

f this is really planned change, then it's one of most undesirable, unfortunate, not to say absurdal change could be done. There are several reasons for that:

1. common interests: favourites are one of best tools for searching new, insteresting posts. I can't stress enough how many times I did find something nice when I was browsing favs of users who've had similar taste (we've favoured the same posts) as me. Some users even got favs of others in their subscription lists. Not me, but I've seen such cases few times.
2. feedback: seeing your posted post favoured (and by whom) is one of better feedback you can get on this site
3. no complains: at least on forums there was no single complain about this feature! If there were any, then I assume they were send directly to the admin. Still, even in that case this matter should be discussed at forums first, not removing something that just worked fine. Now we have to belive that there were "many complains" for that. On what basis? How much is "many of them"? Two users who've payed their 20$ for an account? Three of them?
4. nonsense: protecting list of favourites is silly and has no sense of it whatsoever. We are all here only avatars, for pete sake. 100% anonimity. If by chance someone feels uneasy about others peeking to his fav list because he feels his username is not (no longer) anonymous enough then he always has option to ask admin for username change.

And I strongly disagree with adding option of getting your favs private. It still wouldn't have any logical sense to implement it, yet probably many of users would turn it on, "just in case" and "other have turned it off, then I'll do it too". Ending with known result.

Removing visible list of favs from posts was a bolt from the blue. I've lost ties with people I even don't remember their nicks precisely. Without this feature this site is dead for me. Just stating a fact. Maybe other users won't miss this feature so much as me, but there is no doubt that removing it is a big step backward.

[ToksT]

r-ichi-e, I'm pretty sure Albert intends to add it at some point, just not until the more serious issues are fixed.
If he had no plans to add it, he would have already closed this issue with a wontfix.

And it's not very productive to say things like "I'm quitting this site if you don't add my favorite feature back".

And finally, it is still possible for a userscript to display the list of people who favorited it. One hasn't been made yet, but I'm sure one will be if Albert never does add this himself.

[r-ichi-e]

ToksT, what you're saying strongly contradicts with what albert's already said on the forum: http://danbooru.donmai.us/forum_posts/84029

I'm not throwing tantrum here. Quite the contrary: I've presented my logical arguments. If albert will still insist on removing the feature without any logical reason (as it is for now), then the signal for me is loud and clear. That's all.

[r888888888]

1. Some people don't want to share their interests. If you use the same username you use for your blog/twitter/whatever, and you favorite preteen art, then maybe you don't want to expose that to the public.
2. You can get that feedback from the score.
3. The complaints have been private. People constantly email me about changing their username, because they don't want to be associated with the posts they favorite.
4. See above.

I haven't made a decision one way or the other but I just wanted to present the counterarguments.

[r-ichi-e]

In other words, whole problem comes down to people who are registering with their widely recognizable nicks and then are finding out that their loli porn favs are visible to other users too?

"The Site is allowed to make public everything else, including but not limited to: uploaded posts, favorited posts, comments, forum posts, wiki edits, and note edits."

Did they ever read the ToS?!

To be absolutely honest, I can't ultimately condemn them for that. Let's see how it works in practice:

• Anonymous (not registered) users can't see registered users' favs (of course).
• Even basic users still can't see registered users' favs (that's disputable but I don't want to delve deeper into it now).

So, if basic user gets promoted, two things happens:

1. he can see (and fav) all loli/shota posts now
2. he finally finds out that all his favs were, are and will be visible to the others

But... he has already registered under such nickname and not the other! And who (carefully) reads the ToS when registering free account somewhere...? But when free account becomes better, premium one... yeah, right.

So how about adding suitable disclaimer at the sign up page http://danbooru.donmai.us/users/new ?
"Danbooru is open community, with easy access to many users's actions. This includes history of posting, tag changes, comments (blahblahblah), access to other users' subscriprion lists and favorites. Please choose your username carefully to avoid any possible inconvenience in the future".
Or something similar, preferably in better english than mine.

I strongly protest against removing the useful feature only because of complaints issued by those who haven't read the ToS.

[ToksT]

In Danbooru 1, were the users in the list separated by spaces or commas?

And also, was the list from most recent favorites at the top to least recent favorites? Or the opposite?

[RaisingK]

Commas, and most recent first.

[ToksT]

Only thing that commit is missing is a link to un-show the list after you've opened it up. This should be enough for now, though.

[MyrMindservant]

Is option to make your favorites private (hidden) already implemented? Personally, I don't need it, but from what Albert has said there are many users opposed to sharing/showing their favorites. I think such option should be made available before this functionality is readded to the site.

[ToksT]

No, it isn't implemented. But you can already view anyone's favorites just by searching for fav:name. Also, this feature is limited to Gold+, while searching for fav:name isn't. And you can already see a post's favorite list easily if you use a userscript (which is also not limited to Gold+). So adding this favorite list doesn't seem to make favorites any less private, to me.

[RaisingK]

Can the show/hide link look/work the way Tweaks does it?

[ToksT]

It currently looks like ». I think that looks better than >>, personally. And it seems more consistent with the rest of the site.

[ghost]

While you mentioned userscripts, is it really alright for any member to be able to access this feature just by inserting the link? Also, would it be possible to achieve something similar looking to what the following bookmarklet does for posts with a notable number of favorites (the extreme examples)? I know I used to hate it when all the stuff below the favorites got shoved down into oblivion.

javascript:(function(){var postID = /\d+/.exec(location.pathname), favItem = document.getElementById("favcount-for-post-" + postID).parentNode; if (favItem.children[1]) { favItem.removeChild(favItem.children[1]); } favItem.innerHTML += '<span id="favlist-for-post-' + postID + '"><a href="/favorites?post_id=' + postID + '" data-remote="true">Test Me</a></span>'; var favList = document.getElementById("favlist-for-post-" + postID); favList.children[0].addEventListener("click", function() { favList.innerHTML = ""; favList.style.display = "block"; favList.style.maxHeight = "200px"; favList.style.overflowY = "auto"; var favListTimer = setInterval( function(list){return function() { if (/<br>/.test(list.innerHTML)){ list.removeChild(list.children[0]); clearInterval(favListTimer); } };}(favList) , 125);}, false);})()

[ToksT]

While you mentioned userscripts, is it really alright for any member to be able to access this feature just by inserting the link?

Is this different from Danbooru 1?

And it's always going to be possible to add it with a userscript, so I'm not sure that going out of my way to make the userscripts a bit harder to write but not impossible would be worth it. Not IMO, at least.

Also, would it be possible to achieve something similar looking to what the following bookmarklet does for posts with a notable number of favorites

Nice idea, that does look better. #1346

[r-ichi-e]

Commas, and most recent first.

Uhm... not that it matters much but I'm fairly sure it was the opposite (most recent last).

Is this different from Danbooru 1?

If there is something really different from D1, then it's the possibility to check all user profiles (and thus favs) while being not logged in. You can even use http://danbooru.donmai.us/posts/#post?tags=fav:username syntax and the pool bar with favs navigation will work too. Personally I think it's a little bit too far. Of course, it's not a big deal as it's not a problem to create a basic account and sign in anytime. But I also see no reason, why outsiders who don't even care to sign up should have an access to all this data.

Nice idea, that does look better. #1346

As long as it could be turned off please... or at least, the "notable" number could be somehow regulated. This extra bar makes space for the list even smaller, and if you really want to check whole list you have to scroll it even more than you'd have to with whole screen. Perhaps simple collapse button would be more useful here.

[ToksT]

As long as it could be turned off please... or at least, the "notable" number could be somehow regulated. This extra bar makes space for the list even smaller, and if you really want to check whole list you have to scroll it even more than you'd have to with whole screen.

The bar is not very wide at all, and it only appears on posts with a lot of favorites. The maximum height could be tweaked, but I don't see why an option to turn it off would be necessary.

Perhaps simple collapse button would be more useful here.

By that, you mean a link that hides the favlist, and lets you toggle it? I already added that.

[r-ichi-e]

The bar is not very wide at all, and it only appears on posts with a lot of favorites.

Of course, by talking about "a lot" you meant, I don't know 500 favs, maybe 400... 300? You surely didn't mean so popular and small number of favs like under 100... oh, wait.
BTW, if I may suggest anything - the width of the left margin is waaay to small. Same goes with the width of the scrolling bar of course. Please go ahead, and make them so big that we'll be forced to read every single username separately, even better: vertically, in traditional japanese style. Only that way we'll be able to fully appreciate the enjoyment coming from scrolling down such list. To oblivion.

By that, you mean a link that hides the favlist, and lets you toggle it? I already added that.

Very well, and this is what resolves the problem of "stuff below the favorites got shoved down into oblivion". Because if someone is seeing high number of favs, then he should know what to expect after he clicks expand button. And even if not, collapse button allows him to easily repair the "mistake" he did by expanding such (long) list.

tldr; This scrollbar is absolutely unncecesary and only makes thing worse. Same goes with this "wtf?" left margin. The space there is very limited, and to make the best use of it it's vital not to waste it further. Not to mention that such scrollbar is absolutely out of the site design. Is anywhere else at Danbooru such scroll bar implemented? No. And there is lot of places where it could be. For example how about inserting in the "too long" tag lists. Should I assume that in such case there is no problem with "stuff below got shoved down to oblivion"? We could also implement such scroll bar for too long pictures. And to the comments column if it becomes too large. I mean, why should we always scroll whole page, and it will certainly look better, hm?

[ToksT]

I'll remove the margin and/or the scrollbar if other users agree with that. So far we have one person who wants the margin, one who wants the scrollbar, and one who wants neither. I do not care too much, personally. You can ask on the forum if you want to get more opinions.

[Sal-N]

@r-ichi-e: http://i.imgur.com/48MWUSK.jpg

But I agree with removing the margin and the scrollbar. It looks much better that way. Stuff being shoved into oblivion problem in D1 had already been solved with the collapse button.

[RaisingK]

I agree with removing the scrollbar, but only that much. I like having the margin to visually separate it from what follows after it, and it doesn't extend the favlist that much.

[r-ichi-e]

@Sal-N @_@

I've exploded because I was sick and tired seeing once again the same routine here, i.e. another out of the blue idea, being applied almost immediately. Yet, if you try to point out that actually such changes aren't the best and in fact the previous status quo was better, then you're expected to produce diligent, perfectly argumented pamphlet. Which will be, at best, subjected to some kind of voting procedure, with estimated time of conclusion two months later.

I'll remove the margin and/or the scrollbar if other users agree with that.

Yup, here we go again.
How about adding the margin and/or scrollbar if other users agree with that first?

Dear devs, perhaps if you stop using this fait accompli policy then probably it'll be much easier not to get nervous. Thank you for your consideration.

I like having the margin to visually separate it from what follows after it, and it doesn't extend the favlist that much.

Visual separation? They are linked-blue, for me this is more than enough. And because of all these line unbreakable long usernames, each pixel of space is goldworthy here.
BTW, would this left-margin be script-modable somehow? (to make things clear: the one in currrent danbooru code, not the one included in miscellaneous tweaks fav info)

[ToksT]

How about adding the margin and/or scrollbar if other users agree with that first?

Those were suggested by other users, and no one disagreed with them. If I waited for dozens of people to voice their agreement before making a change, then I would never get to make any changes at all.

BTW, would this left-margin be script-modable somehow? (to make things clear: the one in currrent danbooru code, not the one included in miscellaneous tweaks fav info)

What do you mean by "modable"? You could easily get rid of it with either JS or CSS, if that's what you're asking.

[r-ichi-e]

Those were suggested by other users, and no one disagreed with them.

UserS? I can see only one here, the one who proposed it. Did I miss something? And after his proposal I've actually started to politely argue, but in the meantime you've commisioned this with speed of light.

If I waited for dozens of people to voice their agreement before making a change, then I would never get to make any changes at all.

Aha. And what is important in development: making changes for sake of making changes or the final result?
Please don't respond, I already know your answer.

[ToksT]

I tweaked the size of the margin/height of the favlist.

Did I miss something?

Yes. @RaisingK requested the margin, while @Moebius-Strip requested the scrollbar. And I agreed with them.

[r-ichi-e]

That's still one user per every request. A massive support indeed.

[ToksT]

If you think that sarcasm is supporting your point then I have bad news for you.

[Lightforger]

-someone posts a request/suggestion/something
-a coder agrees & implements it.

Seems pretty logical to me, most issues here go like that, with the occasional "+1/-1". Since the only way to agree/disagree/vote is leaving a comment, the average issue involves 2-4 people.

As ToksT said (right before Sal-N commented), it was 1v1 about the margin/scrollbar - both with valid points, so, he asked to get some more opinions. It's very different from the usual 2v0.

.
Anyway.... about the issue
I completely agree with:

RaisingK commented:
I agree with removing the scrollbar, but only that much. I like having the margin to visually separate it from what follows after it, and it doesn't extend the favlist that much.

The scrollbar.. if i clicked "show me all 500 favorites", i wouldn't expect a tiny 300px box that scrolls forever.
The margin.. no real opinion - without scrollbar it doesn't matter that much. (a border-left would be more space-efficient in the already small sidebar, but probably looks worse than the margin)

[ToksT]

I sort of preferred the scrollbar, as you didn't need to scroll to the bottom of the page (losing sight of the image and favlist-toggle button in the process) to see the whole list. But as the majority seem to favor removing it, I'll do so.