Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user setting to change default ?limit=number on post searches #959

Closed
ToksT opened this issue Mar 18, 2013 · 10 comments
Closed

Add user setting to change default ?limit=number on post searches #959

ToksT opened this issue Mar 18, 2013 · 10 comments
Labels

Comments

@ToksT
Copy link
Contributor

ToksT commented Mar 18, 2013

For example, if the user set this option to 18, then /posts would behave like /posts?limit=18 for that user. This setting should have limits, such as a minimum of 10 posts per page and a maximum of 30 or so.

Reason: Users with different screen widths will have different arrangements of posts. The default of 20 posts looks good if the number of columns of posts is a number that 20 is divisible by, but less so if it isn't. If 6 columns fit on your screen, then the lowermost row will have only 2 posts. This option would let users change this if it bothers them. eg. A limit of 18 or 24 would fit with 6 columns.

Edit: If #987 is fixed, then this option should work with those pages as well. Possibly with different settings for each page, because they have different layouts.

Edit: The max limit for posts per page could be dependent on user level.
Example: Members can have up to 30 per page, Gold can have 50, Platinum+ can have 200.

@ghostrigger
Copy link
Contributor

just to add, the post limit maximum is currently 200.

@Cardboardgundam
Copy link

Would be even better if there's a separate limit for pool pages since those have no tag list and more room.

@RaisingK
Copy link
Collaborator

30 is too low for a maximum. And if this is implemented and with a maximum, I don't want this to affect the limit's effect on API calls...

@ToksT
Copy link
Contributor Author

ToksT commented Mar 18, 2013

@RaisingK The purpose of this suggestion was so that people can adjust the results to fit their screen, and 30-40 should be enough for that (although it's just a rough guess). And I don't think the limit for the API should be lowered or anything; that should stay at 200 if this is implemented

@RaisingK
Copy link
Collaborator

A 40-50 max for this is my preference, if not the same max as the API.

@Sal-N
Copy link
Contributor

Sal-N commented Mar 19, 2013

I agree with RaisingK, max limit should be at least 50 if not 200.

@ToksT
Copy link
Contributor Author

ToksT commented Mar 19, 2013

Another possibility would be to give a different max to different user levels. eg. Members can have up to 30 per page, Gold can have 50, Platinum+ can have 200. Just a thought; not sure if that would be necessary or not.

@RaisingK
Copy link
Collaborator

A script can handle post searches just fine by inserting limit=X into all the links. But that's the only place limit=X works. It's the other pages where this can apply (note/index, pool/show, etc...) that I'm really interested in...

@ToksT
Copy link
Contributor Author

ToksT commented Mar 20, 2013

@RaisingK Made a new issue for that instead: #987

@ROMaster2
Copy link

I support ToksT's idea for level based maximums.
I also think display limits are better than page limits. 5000 is nice but you will always time out. Increasing the maximum number on the limits is better. It'd nice if Platinum+ had 500 or 1000, I used it when scrapping data, not displaying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants