Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css fix for wide screens. #906

Merged
merged 8 commits into from Mar 17, 2013
Merged

css fix for wide screens. #906

merged 8 commits into from Mar 17, 2013

Conversation

Lightforger
Copy link
Contributor

First time working with git / pull requests, please point out any mistakes :).

The base idea is removing the set width & float from "section#content", making it overlap the sidebar, then assigning a margin-left which makes the sidebar visible again.
Same for wiki pages & forum posts.

All pages with both a sidebar & "#content" need to have a margin added (cannot be added to "#content" itself, otherwise it appears on pool pages & such as well). Tested all that i could think of, but may have missed one.

Tested in opera / firefox / chrome.

@kotarou3
Copy link
Contributor

Firstly, it would be much better if you had more descriptive commit messages, and secondly, you could have done all the files in a single commit.
Also, notice the surrounding coding style for posts.css: We have spaces after the colons, so I recommend you follow that.
Apart from that, it seems good to me, though I haven't actually tested this.

r888888888 added a commit that referenced this pull request Mar 17, 2013
@r888888888 r888888888 merged commit cfdf449 into danbooru:master Mar 17, 2013
@Lightforger
Copy link
Contributor Author

From other edits i could see people change multiple files in a single commit, but didn't see how to save a file except with "commit changes". Only one answer on google, which was with command line, so i'm probably missing something obvious >.<
Will double-check for spaces next time.

@kotarou3
Copy link
Contributor

Yea, you have to install git and do it from the command line.
Here's a guide if you want to still do it: https://help.github.com/articles/set-up-git

@Lightforger
Copy link
Contributor Author

Seems like quite a bit of work just to be able to compress commits.
Maybe later *bookmarks link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants