Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed C++ source into the repository #7

Closed
r9y9 opened this issue Mar 19, 2021 · 0 comments · Fixed by #8
Closed

Embed C++ source into the repository #7

r9y9 opened this issue Mar 19, 2021 · 0 comments · Fixed by #8

Comments

@r9y9
Copy link
Owner

r9y9 commented Mar 19, 2021 •
edited

With this, users will not need to build open_jtalk C++ library in advance.

This can be done as in https://github.com/r9y9/pysptk. Compiling C++ sources with cython would be tricky though, it should be possible.
r9y9 added a commit that referenced this issue Mar 20, 2021
@r9y9
Embed C++ source into the core openjtalk module
6f105f8 
ref #7
@r9y9 r9y9 mentioned this issue Mar 20, 2021
Merged
@r9y9 r9y9 closed this as completed in #8 Mar 21, 2021
r9y9 added a commit that referenced this issue Mar 21, 2021
@r9y9
Merge pull request #8 from r9y9/goodbye-openjtalk-shared-lib
e566287 
Goodbye openjtalk shared lib

fixes #7
@r9y9 r9y9 mentioned this issue Mar 23, 2021
Closed
@r9y9 r9y9 mentioned this issue Aug 9, 2021
Closed
Hiroshiba added a commit to Hiroshiba/pyopenjtalk that referenced this issue Jan 31, 2022
@Hiroshiba
Revert "openjtalkを1.11にアップデート (r9y9#6)" (r9y9#7)
f3dfdb6 
This reverts commit 9a99880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Goodbye openjtalk shared lib r9y9/pyopenjtalk
1 participant
@r9y9