c2acr: Fix segfaults for small fftsize

r9y9 · Aug 8, 2017 · 74bc912 · 74bc912
1 parent 0d92551
commit 74bc912
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # News for pysptk
 
+## v0.1.8
+
+- c2acr: Fix segfaults for small fftsize
+
 ## v0.1.7
 
 - Extend vec2vec functions to mat2mat [#49]

diff --git a/pysptk/_sptk.pyx b/pysptk/_sptk.pyx
@@ -430,6 +430,8 @@ def c2acr(np.ndarray[np.float64_t, ndim=1, mode="c"] c not None,
           order=None,
           fftlen=256):
     assert_fftlen(fftlen)
+    if len(c) > fftlen:
+        raise ValueError("fftlen must be larger than length of input")
     cdef np.ndarray[np.float64_t, ndim = 1, mode = "c"] r
     cdef int src_order = len(c) - 1
     if order is None:

diff --git a/tests/test_conversions.py b/tests/test_conversions.py
@@ -109,6 +109,9 @@ def __test_fftlen(fftlen):
     for fftlen in [257, 513]:
         yield raises(ValueError)(__test_fftlen), fftlen
 
+    def __test_small_fftsize():
+        yield raises(ValueError)(__test_fftlen), 16
+
 
 def test_c2ir():
     for order in [15, 20, 25, 30]: