Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-GPU Support #50

Closed
ddemilla opened this issue Apr 15, 2018 · 9 comments
Closed

Multi-GPU Support #50

ddemilla opened this issue Apr 15, 2018 · 9 comments

Comments

@ddemilla
Copy link

Are there any plans to add multi-gpu support? I didn't see anything in the TODO list. Thanks!

@r9y9
Copy link
Owner

r9y9 commented Apr 15, 2018

No plans, because I have only 1 GPU:( Contributions are very welcome. FWIW, see #1 (comment)

@ddemilla
Copy link
Author

Ok thanks, I haven't done much work in PyTorch but I will take a stab at it.

@azraelkuan
Copy link
Contributor

@ddemilla for multi gpu training, you will need to fix the code to use cpu to run the eval_model function in train.py or you can do not run it in training process.

@ddemilla
Copy link
Author

@azraelkuan Thanks, I will keep that in mind. I just had my gpu quot increased on gcloud so I will start experimenting tonight!

@r9y9
Copy link
Owner

r9y9 commented Apr 27, 2018

This should be fixed by #55. Feel free to reopen and leave comments if you have further requests. Thanks again, @azraelkuan,

@r9y9 r9y9 closed this as completed Apr 27, 2018
@zhang-jian
Copy link

why we need "for multi gpu training, you will need to fix the code to use cpu to run the eval_model function in train.py or you can do not run it in training process."? Thanks

@azraelkuan
Copy link
Contributor

@zhang-jian, because in eval mode, we only use one gpu to generate samples which will waste other resources. In my code, i use os.cmd() run the synthesis.py to eval a complete sentence.

@zhang-jian
Copy link

Clear now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants