Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the oom problem of synthesis and fix dependecy of deep-voice3 #55

Merged
merged 8 commits into from
Apr 27, 2018
Merged

fix the oom problem of synthesis and fix dependecy of deep-voice3 #55

merged 8 commits into from
Apr 27, 2018

Conversation

azraelkuan
Copy link
Contributor

sorry to open a new PR.

r9y9
r9y9 reviewed Apr 27, 2018
View reviewed changes
Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I have added a minor comment, others LGTM.

As for dropping deepvoice3 dependency, setup.py needs to be adjusted but I can fix it later.

wavenet_vocoder/__init__.py Outdated
@@ -1,6 +1,5 @@
# coding: utf-8
from __future__ import with_statement, print_function, absolute_import

from .version import __version__
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@r9y9 r9y9 merged commit 5b54777 into r9y9:master Apr 27, 2018
This was referenced Apr 27, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r9y9 r9y9 r9y9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azraelkuan @r9y9