docs(readme): Update Sentry docs #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issy
reviewed
Nov 7, 2021
| @@ -242,6 +242,8 @@ Send unhandled errors and performance metrics to sentry. | |||
|
|
|||
| Configure Sentry DSN using `[p]set api sentry dsn,https://fooo@bar.baz/9`, then load the Cog `[p]load sentry`. | |||
|
|
|||
| Requires `pip install -U sentry_sdk`. | |||
There was a problem hiding this comment.
We shouldn't need to specify this in the documentation. The pip requirements are defined in the info.json file for the cog, and should be installed automagically when you run [p]cog install <cog_name>
Feel free to correct me if there's an issue with sentry_sdk not installing when the cog is installed.
There was a problem hiding this comment.
Did not know that was a feature. Dope.
I think it's just typo'd in sentry/info.json#L13 then. I'll kill this and fix that.
Thanks Issy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Checklist
Details
Does this resolve an issue?
No
Changes
Features / Fixes
N/A.
Breaking Changes
N/A.
Additional
Update Sentry docs - Added requirement.