Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "close tab" with single-tab window malfunctions #264

Closed
Luckz opened this issue Dec 22, 2021 · 3 comments
Closed

Bug: "close tab" with single-tab window malfunctions #264

Luckz opened this issue Dec 22, 2021 · 3 comments

Comments

@Luckz
Copy link

Luckz commented Dec 22, 2021

On Chrome at least (didn't test on FF), it's always™ been the case that the close tab function (as assigned to a hotkey f.ex.) can break horrendously if you have a single-tab window in front. It can instead close the active tab of another window, I suppose when switching to another window with more tabs while ATD is still looking for that first tab to close (?), and this is really hard to spot for the user – either they quickly ctrl-shift-T after it happens, or they lose a tab forever without even knowing about it.

The peculiar thing is that this can happen several minutes after pressing the hotkey.

@rNeomy
Copy link
Owner

rNeomy commented Dec 26, 2021

I think I found the issue. Please reopen if you are still experiencing it after the 0.4.9 release.

@rNeomy rNeomy closed this as completed Dec 26, 2021
@Luckz
Copy link
Author

Luckz commented Dec 27, 2021

Now that you fixed that infinite loop problem, it seems safe to use. 👍🏻

Is it by the way WAD that the Close Tab hotkey (see above) won't close the last tab in a window?

@rNeomy
Copy link
Owner

rNeomy commented Dec 29, 2021

Is it by the way WAD that the Close Tab hotkey (see above) won't close the last tab in a window?

No! Just a bug that is now fixed! Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants