Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of get_eurostat_geospatial #263

Closed
pitkant opened this issue Jun 28, 2023 · 2 comments · Fixed by #264
Closed

Future of get_eurostat_geospatial #263

pitkant opened this issue Jun 28, 2023 · 2 comments · Fixed by #264

Comments

@pitkant
Copy link
Member

pitkant commented Jun 28, 2023

Executive summary

Two alternative paths for package development:

  • Retire all internal mapping related functions (get_eurostat_geospatial()) and provide improved documentation / vignette and potentially some helper functions for giscoR package.
    • Would make eurostat package more lightweight, more focused on just retrieving statistical data
    • Would make it maybe less useful for less experienced end users?
  • Retire only code, examples and tests related to using sp package
    • Provides backward compatibility, gives more time to soft deprecate functions if we so wish

Deadline

October 2023

Background

To make map visualization easy for end users eurostat has had built-in functions to visualise Eurostat data on a map and has included sf and sp packages as Imports. However, in 2023 rgdal, rgeos and maptools packages will be retired and sp package will evolve, having sf at minimum as a weak dependency.

More information from this message and in the link:

The legacy packages maptools, rgdal, and rgeos, underpinning this package
will retire shortly. Please refer to R-spatial evolution reports on
https://r-spatial.org/r/2023/05/15/evolution4.html for details.

Other considerations

@pitkant
Copy link
Member Author

pitkant commented Aug 1, 2023

Addressed in v4-dev branch and PR #264. Relying on giscoR package in get_eurostat_geospatial functionalities will be the way to go in the future.

I will close this issue when v4 is released

@pitkant pitkant moved this from To do to In progress in eurostat 4.0.0 Aug 1, 2023
@pitkant pitkant linked a pull request Aug 11, 2023 that will close this issue
@pitkant pitkant moved this from In progress to Done in eurostat 4.0.0 Aug 17, 2023
@pitkant
Copy link
Member Author

pitkant commented Dec 20, 2023

Closed with the CRAN release of package version 4.0.0

@pitkant pitkant closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant