Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that libgdal-dev is necessary to install on Debian/Ubuntu or make the sf package optional #213

Closed
paulrougieux opened this issue Jun 17, 2021 · 2 comments · Fixed by #264

Comments

@paulrougieux
Copy link
Contributor

paulrougieux commented Jun 17, 2021

This is a request to :

  1. either document the sf dependency and GDAL requirement with an additional error message.
  2. or make the sf dependency optional (since the eurostat data download doesn't depend on it and since GDAL is quite a heavy library to install)

Installation failed on Debian because of a missing GDAL dependency for the sf package. The sf package is itself a dependency of the eurostat package (as visible in the imports of the DESCRIPTION file). Some packages print a message when the installation fails, that suggest installing the required packages at the system level. The message in this case could be:

Please install the GDAL development library 

   sudo apt install libgdal-dev

Maybe this installation instruction should actually be notified when the sf package fails to install? The Ubuntu dependencies are actually specified in the sf readme, but a hint in the installation process would make the installation smoother.

@paulrougieux paulrougieux changed the title Specify that libgdal-dev is necessary to install on Debian/Ubuntu Specify that libgdal-dev is necessary to install on Debian/Ubuntu or make the sf package optional Jun 17, 2021
@antagomir
Copy link
Member

Good point.

As a primary solution, I would suggest dropping sf from Dependencies to Imports/Suggests if this helps.

But adding our own Ubuntu (and other) dependencies section in the same way than in sf package would be helpful as well.

@pitkant
Copy link
Member

pitkant commented Dec 20, 2023

Should now be fixed with the package version 4.0.0. If the problem persists please open a new issue.

@pitkant pitkant closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants