Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved cache handling #267

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Improved cache handling #267

merged 11 commits into from
Aug 17, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Aug 11, 2023

  • Use md5 hash as cache file name to check if a file has already been cached
  • Calculate md5 hashes pre-emptively for filters = NULL queries to check if a superset of desired dataset already exists in cache
  • Allow caching for all datasets, including filtered datasets, instead of just bulk downloads

Fixes issues in #144, #257 and #258.

@pitkant pitkant mentioned this pull request Aug 11, 2023
Closed
This was linked to issues Aug 11, 2023
cache filtered tables, suggestion of functionality #144
Closed
Cached datasets #257
Closed
get_eurostat() does not save .rds files #258
Closed
@pitkant pitkant added this to In progress in eurostat 4.0.0 Aug 11, 2023
@pitkant pitkant marked this pull request as ready for review August 15, 2023 12:46
@pitkant pitkant requested a review from antagomir August 15, 2023 12:47
antagomir
antagomir approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very thorough, no specific additional comments come to mind.

@pitkant pitkant merged commit be2b98d into v4-dev Aug 17, 2023
eurostat 4.0.0 automation moved this from In progress to Done Aug 17, 2023
@pitkant pitkant mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antagomir antagomir antagomir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
eurostat 4.0.0
Done
Milestone
No milestone
2 participants
@pitkant @antagomir