Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Fix undefined columns error and update README.md #25

Merged
merged 2 commits into from
Dec 22, 2017

Conversation

jlintusaari
Copy link
Contributor

@jlintusaari jlintusaari commented Dec 22, 2017

Fix the "undefined columns error" when using the function client$getDailyWeather. Also add Ubuntu installation instructions to readme.md.

Jarno Lintusaari added 2 commits December 22, 2017 09:56
Add Ubuntu instruction also to README
@jlintusaari jlintusaari changed the title Update README.md Fix undefined methods error and update README.md Dec 22, 2017
@jlintusaari jlintusaari changed the title Fix undefined methods error and update README.md Fix undefined columns error and update README.md Dec 22, 2017
@antagomir antagomir merged commit 60950f5 into rOpenGov:master Dec 22, 2017
@antagomir
Copy link
Member

Thanksss !!

@jlehtoma
Copy link
Contributor

Thanks a lot @lintusj1 . fmi is still very much in development and one thing which has changed - but was not yet reflected in README - is that since 0.2.0 a working installation of GDAL is not needed anymore. fmi imports rwfs which in turn imports sf which does depend on GDAL2. Since this is an upstream dependency, I've removed all installation instructions from fmi.

Nice work with tracing the changed field name!

@jlintusaari
Copy link
Contributor Author

Thanks! I'm not sure if it would be better to still have those instructions. At least for me the package didn't work until I installed the GDAL packages. It may be quite difficult for a user to track what's failing in an upstream package.

@jlehtoma
Copy link
Contributor

jlehtoma commented Jan 4, 2018

Which version of fmi and rwfs were you using? I think sf binary installation on Windows contains the necessary GDAL library. In addition, the latest versions of fmi and rwfs don't use GDAL CLI tools anymore (which required a functional GDAL installation).

@jlintusaari
Copy link
Contributor Author

fmi version: 0.2.0
rwfs version: 0.1.16

I was using Ubuntu 16.04.

@jlehtoma
Copy link
Contributor

jlehtoma commented Jan 5, 2018

Thanks again! rwfs >= 0.2.0 gets rid of the GDAL CLI tools so updating should remove the need for a separate GDAL installation. Would love to hear if this really is the case if you have time/interest to test.

@jlintusaari
Copy link
Contributor Author

I wonder if it would be good to update the dependency version requirement also. I installed fmi from CRAN and it's description states that:

Imports: rwfs (>= 0.1.12), dplyr, magrittr, sp, tibble, tidyr, rgdal, raster

For some reason it didn't automatically install 0.2.0 and although possible, I don't think I had previously rwfs installed.

@jlehtoma
Copy link
Contributor

jlehtoma commented Jan 5, 2018

AFAIK, fmi is not on CRAN - yet. It certainly is a good idea to update the import version requirement and this has been done in master of fmi (currently on 0.2.1).

@jlintusaari
Copy link
Contributor Author

Ok very good, I probably remembered wrong and used install_github from devtools.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants