Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ternary colors plots? #8

Closed
antagomir opened this issue Nov 14, 2018 · 7 comments
Closed

Ternary colors plots? #8

antagomir opened this issue Nov 14, 2018 · 7 comments

Comments

@antagomir
Copy link
Member

Ternary color plots would be a very nice addition to gisfin set. @janikmiet has implemented this for Finnish maps. See also Github.

@muuankarski muuankarski transferred this issue from another repository Aug 6, 2019
@janikmiet
Copy link
Collaborator

Package tricolore is needed for ternary color plots. Started writing a vignette for this which is based on current vignette.

@antagomir
Copy link
Member Author

Great!

@jlehtoma
Copy link
Contributor

As far as I could tell, this is now implemented here. Is it ok to close this issue?

@janikmiet
Copy link
Collaborator

Yes, issue can be closed. I don't have rights to do that.

@muuankarski
Copy link
Collaborator

@janikmiet Could you have a look at the vignette? The last code chunk gives an error

Error in titleGrob(label, x, y, hjust = hj, vjust = vj, angle = angle, : unused argument (expand_y = TRUE)

@tts
Copy link

tts commented Apr 5, 2021

If I'm not mistaken, in the vignette code example, either the order of tric_dat keys needs to be changed here or ditto with the legend labs here (probably the latter). As it is now, age groups under_15 and over64 are backwards.

@janikmiet
Copy link
Collaborator

@tts Good that you noticed! You are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants