Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for years #12

Closed
vsaaristo opened this issue Nov 14, 2023 · 1 comment · Fixed by #24
Closed

Default value for years #12

vsaaristo opened this issue Nov 14, 2023 · 1 comment · Fixed by #24
Assignees
@pitkant

Comments

@vsaaristo
Copy link
Contributor

The default for GetDataSotkanet() could be something else than 1991:2015, as many indicators only have data for latest years.
@pitkant
Copy link
Member

pitkant commented Nov 20, 2023

Thank you for opening the issue. I don't recall why the default value for years argument is that one, maybe it's legacy and maybe because it's useful to show that value for years can be inputed with the colon operator as a list of years.

Maybe a better option would be to set that to examples and use NULL as default value.

@pitkant pitkant linked a pull request May 28, 2024 that will close this issue
Change get_sotkanet default years, add function sotkanet_indicators_metadata and move from httr to httr2 #24
Merged
@pitkant pitkant closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitkant pitkant

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vsaaristo @pitkant