Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from httr to httr2 #19

Closed
pitkant opened this issue May 17, 2024 · 1 comment · Fixed by #24
Closed

Switch from httr to httr2 #19

pitkant opened this issue May 17, 2024 · 1 comment · Fixed by #24
Assignees

Comments

@pitkant
Copy link
Member

pitkant commented May 17, 2024

httr package is marked in R lifecycle terms as superseded. This means generally speaking that

A softer alternative to deprecation is superseded. A superseded function has a known better alternative, but the function itself is not going away . A superseded function will not emit a warning (since there’s no risk if you keep using it), but the documentation will tell you what we recommend instead .

Superseded functions will not receive new features, but will receive any critical bug fixes needed to keep it working. In some ways a superseded function is actually safer than a stable function because it’s guaranteed never to change (for better or for worse).

and in the specific case of the httr package that

httr is superseded: only changes necessary to keep it on CRAN will be made.

I think it would make sense to update even existing functions from httr to httr2, since httr2 is more modern, is already used in e.g. the eurostat package and it is probably easier to maintain functions using httr2 in the future due to better documentation. Special care has to be taken to ensure that the returned data object is identical to the old one. Error message handling can differ from old implementation. Writing completely new functions in httr2 is also a no-brainer.

@pitkant
Copy link
Member Author

pitkant commented May 28, 2024

Fixes to PR #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants