Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvmrc updated to version 14.17.5 #18

Merged
merged 3 commits into from Oct 2, 2021
Merged

nvmrc updated to version 14.17.5 #18

merged 3 commits into from Oct 2, 2021

Conversation

JVisuri1
Copy link
Contributor

@JVisuri1 JVisuri1 commented Oct 2, 2021

#16

@JVisuri1 JVisuri1 mentioned this pull request Oct 2, 2021
Closed
ra100
ra100 requested changes Oct 2, 2021
View reviewed changes
Copy link
Owner

@ra100 ra100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check why there are "binary" characters?
image

@ra100
Copy link
Owner

ra100 commented Oct 2, 2021

And can you update directly to latest version 16? Thanks :)

@JVisuri1
Copy link
Contributor Author

JVisuri1 commented Oct 2, 2021

Updated to v16.10.0

@JVisuri1 JVisuri1 requested a review from ra100 October 2, 2021 11:07
ra100
ra100 requested changes Oct 2, 2021
View reviewed changes
Copy link
Owner

@ra100 ra100 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What encoding are you using, github still shows me this file as binary, while it should be textfile?
With some special characters.
Can you try to save the file with UTF-8 charset? Or edit it direcly on githu? Thanks.
image

@JVisuri1
Copy link
Contributor Author

JVisuri1 commented Oct 2, 2021

@ra100 For some reason VS Code was opening that file with UTF-16 LE encoding. Now it should be in correct format.
Sorry for the inconvenience.

@ra100 ra100 merged commit 8b639da into ra100:master Oct 2, 2021
@ra100
Copy link
Owner

ra100 commented Oct 2, 2021

@JVisuri1 no problem, glad you figured it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra100 ra100 ra100 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JVisuri1 @ra100