Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setData closure gets called outside of performBatchUpdates #17

Closed
Usipov opened this issue Aug 27, 2018 · 6 comments
Closed

setData closure gets called outside of performBatchUpdates #17

Usipov opened this issue Aug 27, 2018 · 6 comments

Comments

@Usipov
Copy link

Usipov commented Aug 27, 2018 •
edited

Hey! Thanks for an amazing tool
I tried it out in stress tests (will probably share the code later) and found unexpected crashes.
The issue was due to the following code
screen shot 2018-08-27 at 17 40 53

Here setData gets called not inside of performBatchUpdates.
But according to the docs, it should be done inside:

To avoid problems, you should update your data model inside the updates block or ensure the layout is updated before you call performBatchUpdates(_:completion:).
@ra1028
Copy link
Owner

ra1028 commented Aug 27, 2018

Hi @Usipov
Thanks for the precious bug report.
I didn't know that its specification of UICollectionView.

I'll do that in the next release.
I'm waiting for you to share me your stress tests code 👍

@ra1028 ra1028 mentioned this issue Aug 27, 2018
Merged
@ra1028
Copy link
Owner

ra1028 commented Aug 27, 2018

WIP #18

@ra1028
Copy link
Owner

ra1028 commented Aug 29, 2018 •
edited

@Usipov
Could you share me the code of your tests?

@Usipov
Copy link
Author

Usipov commented Aug 29, 2018

@ra1028, WIP

@Usipov
Copy link
Author

Usipov commented Aug 29, 2018

@ra1028, did you receive my email on r.fe51028.r@gmail.com?

@ra1028
Copy link
Owner

ra1028 commented Aug 29, 2018

Thanks @Usipov .
I had missed your mail.
I just replied the mail now.

Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Add stress tests of continous random collection view updat…
cd79607 
…es in a one dimentional collection
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Upgrade stress tests of continous random collection view u…
1adb706 
…pdates in a two dimentional collection
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Improve naming and codestyle
b85db4c
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Fix non UIKit tests
d592ef6
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Revert build configuration change
a649718
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Fix typo
5f214c5
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Fix grammar typo
8fe2ee5
Usipov added a commit to Usipov/DifferenceKit that referenced this issue Aug 30, 2018
@Usipov
ra1028#17: Remove unused code
1554682
@ra1028 ra1028 closed this as completed Sep 2, 2018
ra1028 added a commit that referenced this issue Sep 3, 2018
@ra1028
Merge pull request #20 from Usipov/#17-add-stress-tests
91cd85a 
#17 Add stress tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Usipov @ra1028