Align with Identifiable, Add ContentIdentifiable #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Since the identity component of
Differentiable
is semantically identical to the newIdentifiable
protocol in Swift 5.1, I think it would be beneficial to align the two APIs.Related Issue
#80
Motivation and Context
This allows us to easily conform to
Identifiable
as well asDifferentiable
through a single implementation.Impact on Existing Code
This will break conformance to
Differentiable
in existing imlpementations, unless implicit conformance throughHashable
/Equatable
was used.Implementation Details
ContentEquatable
) and Identification (ContentIdentifiable
) components through the use of protocol composition forDifferentiable
ContentIdentifiable
to that ofIdentifiable