Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all EXCLUDED_ARCHS configs to avoid an error #3

Merged

Conversation

yasuradodo
Copy link
Contributor

@yasuradodo yasuradodo commented Apr 19, 2022

Hi! Thank you for sharing the interesting framework! I was browsing the README and wanted to run some sample apps on my Xcode. And then, I found a setting issue in my env.
Could you check this when you have time?
Thank you 🙏

Pull Request Type

  • Bug fix
  • New feature
  • Refactoring
  • Documentation update
  • Chore

Description

The issue is that M1 Mac without Rosetta cannot run the sample projects.

Could not find module 'iOSApp' for target 'x86_64-apple-ios-simulator'; found: arm64-apple-ios-simulator, at: /*/Build/Products/Debug-iphonesimulator/iOSApp.swiftmodule

To fix the issue, I've removed all EXCLUDED_ARCHS because it looks unnecessary in my env.
But I'm not sure about how intel Mac behaves.

Motivation and Context

I want to run Xcode without Rosetta.

Impact on Existing Code

M1 users will need to use Xcode via Rosetta to run the sample projects.

Screenshot/Video/Gif

Screen Shot 2022-04-19 at 18 27 29

> Could not find module 'iOSApp' for target 'x86_64-apple-ios-simulator'; found: arm64-apple-ios-simulator, at: /*/Build/Products/Debug-iphonesimulator/iOSApp.swiftmodule
@ra1028
Copy link
Owner

ra1028 commented Apr 19, 2022

@yasuradodo
Thanks for your contribution! It seems like these settings are needed only for transition period of Xcode 😅
Basically, I don't maintain .xcodeproj manually so can you update project.yml located under Examples/ and then run make proj instead?

@yasuradodo
Copy link
Contributor Author

yasuradodo commented Apr 19, 2022

@ra1028
Hehe, I didn't notice project.yml 😅
Let me update it.

@ra1028
Copy link
Owner

ra1028 commented Apr 19, 2022

@yasuradodo
LGTM. Thanks!

@ra1028 ra1028 merged commit 1498f42 into ra1028:main Apr 19, 2022
@yasuradodo yasuradodo deleted the fix/RemoveExcludedArchitecturesSimulator branch April 20, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants