Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does set / get commands return a nullable future? #29

Closed
erf opened this issue Jul 9, 2021 · 3 comments · Fixed by #30
Closed

Why does set / get commands return a nullable future? #29

erf opened this issue Jul 9, 2021 · 3 comments · Fixed by #30

Comments

@erf
Copy link
Contributor

erf commented Jul 9, 2021

Why does set and get commands return a Future? (Nullable), when send_object returns a Future ?

Could set/get be changed to always return a Future?
@ra1u
Copy link
Owner

ra1u commented Jul 9, 2021

@erf , this seems corect observation. @ArnaudHeywear what is your opinion on this?

@ghost
Copy link

ghost commented Jul 9, 2021

I don't remember it as a specific choice I made, so it probably comes from the automated migration tool. And yes the observation seems correct

@erf
Copy link
Contributor Author

erf commented Jul 9, 2021

Ok, great. I can make a PR for this later.

@erf erf mentioned this issue Jul 9, 2021
Merged
@ra1u ra1u closed this as completed in #30 Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

have get and set commands return a non-null Future erf/redis-dart
2 participants
@ra1u @erf