Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutmeg script text selection issue #744

Closed
2 tasks done
3813127458 opened this issue Jun 9, 2024 · 5 comments · Fixed by #747
Closed
2 tasks done

Nutmeg script text selection issue #744

3813127458 opened this issue Jun 9, 2024 · 5 comments · Fixed by #747
Labels

Comments

@3813127458
Copy link

3813127458 commented Jun 9, 2024

The Nutmeg script interferes with certain locations in the schematic:

artefact.mp4

Schematic:
BHBM_V4.zip

Qucs-S 24.2.0

Operating System: openSUSE Tumbleweed 20240607
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1
Kernel Version: 6.9.3-1-default (64-bit)
Graphics Platform: Wayland

TODO list:

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 10, 2024

It is a known problem related to representation of a multiline text. I will try to provide a fix if possible. I have added a task list for this issue. The fix of this issue may be not a straightforward task.

@ra3xdh ra3xdh added the bug label Jun 10, 2024
@3813127458
Copy link
Author

... to add, regarding Nutmeg:

  1. It should be possible to edit the Nutmeg script also directly in the schematic (without double clicking the Nutmeg script symbol), in order to be consistent with other blocks like .MODEL or .PARAM, where it is possible.
    Both methods are useful.

  2. The Nutmeg script parser should accept variables, eg. {var1} , defined in a .PARAM block

Maybe you can put this on a feature list for future releases.

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 10, 2024

Multiline text bounding rect is already fixed by #723

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 10, 2024

It should be possible to edit the Nutmeg script also directly in the schematic

This is not possible to implement in the near feature. The schematic editor uses QLineEdit control without border as the properties editor. This control doesn't support mulitline text. It's need to replace every occurrence of this editor by some other text editing control. I don't consider such a massive change because of one simulation.

The Nutmeg script parser should accept variables, eg. {var1} , defined in a .PARAM block

It is not a straightforward task. The Ngspice postprocessor knows nothing about .PARAM and it's need to duplicate them in the .control section. The .PARAM may have incompatible syntax with Nutmeg script and it not possible to handle all cases automatically.

@ra3xdh ra3xdh changed the title Schematic Editor Image Artefact Nutmeg script text selection issue Jun 10, 2024
@ra3xdh ra3xdh linked a pull request Jun 11, 2024 that will close this issue
@ra3xdh
Copy link
Owner

ra3xdh commented Jun 11, 2024

#747 implements blocking of the text editing of the Nutmeg script text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants