Final representation #79
Conversation
* X86_64 removed from _CoqProject
|
travis build seems to fail. Can you check the cryptolib directory and do a make from there. |
I did (or rather I went through the details of the travis build failure) and the error was opaque to me. Preliminary research suggests this might be the issue. |
|
On Sun, Oct 07, 2018 at 09:08:56AM -0700, dangabhi wrote:
> travis build seems to fail. Can you check the cryptolib directory and do a make from there.
I did (or rather I went through the details of the travis build failure) and the error was opaque to me.
Was kinda hoping you would be able to tell me what the issue is there.
Did you try building it locally on your machine ? I will have a look at it.
|
src/Verse/Compile.v
Outdated
| {| setup := Ast.setup i; | ||
| process := Ast.process i x; | ||
| finalise := Ast.finalise i | ||
| {| setupB := Ast.setup i; |
There was a problem hiding this comment.
Since this record is only locally used why cant this be just a tuple ?
There was a problem hiding this comment.
Tuples are uglier to destruct and use once more than two components.
Is there a particular reason you prefer tuples over records?
There was a problem hiding this comment.
Do you want to stick to the record or would just a tuple suffice given that you really use it only once. You can I guess just give it as let (stp,proc,fnl) := whatever in stuff and be done with it.
|
On Mon, Oct 08, 2018 at 09:47:52AM +0000, dangabhi wrote:
dangabhi commented on this pull request.
> }.
Local Definition mkBlocks v x (i : iterator codeT v) :=
- {| setup := Ast.setup i;
- process := Ast.process i x;
- finalise := Ast.finalise i
+ {| setupB := Ast.setup i;
Tuples are uglier to destruct and use once more than two components.
Is there a particular reason you prefer tuples over records?
What you say is true when we use only part of the tuple. In this case
you need all the three components so why not just tuples.
|
Have made some changes to CryptoLib which, I have to guess, you will want to change. But these versions work.
Have not checked code for compilation yet.