Fix example client to avoid deadlock in Close #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example was "giving up" on publish confirmation after the resendDelay. This is not correct because the library will keep track of this confirmation, and it will try to deliver the confirmation. By giving up, we are may leave confirmations un-received in the confirmation channel, which will cause a deadlock during the shut down sequence in Channel.Close. We should not give up on the confirmation and simply wait. Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
Gsantomaggio
approved these changes
Sep 30, 2022
lukebakken
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was "giving up" on publish confirmation after the
resendDelay. This is not correct because the library will keep track of
this confirmation, and it will try to deliver the confirmation. By
giving up, we are may leave confirmations un-received in the
confirmation channel, which will cause a deadlock during the shut down
sequence in Channel.Close.
We should not give up on the confirmation and simply wait.
Fixes #122