New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to increase timeout milliseconds since it's too tight #203

Merged

Zerpet merged 1 commit into rabbitmq:main from t2y:fix-timeout-milliseconds

Jun 21, 2023

Contributor

t2y commented Jun 20, 2023

I found an integration test of #192 failed on windows-latest (1.20). I guess it's a timing issue?

=== RUN   TestIntegrationConsumeCancelWithContext
    integration_test.go:857: Timeout on Close
--- FAIL: TestIntegrationConsumeCancelWithContext (0.27s)

https://github.com/rabbitmq/amqp091-go/actions/runs/5322251884/jobs/9638444129

Zerpet approved these changes

View reviewed changes

Contributor

Zerpet left a comment

I haven't seen this today, but I guess it's fine to bump 100ms.


          Fix to increase timeout milliseconds since it's too tight rabbitmq#192

7af6be0

Zerpet force-pushed the fix-timeout-milliseconds branch from a6ccf40 to 7af6be0 Compare

June 21, 2023 14:32

Zerpet merged commit 2fea75e into rabbitmq:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment