Open file limit not set correctly

Gemfile

@@ -8,7 +8,7 @@ end
 
 group :unit do
   gem 'berkshelf'
-  gem 'chefspec'
+  gem 'chefspec', '~> 4.0'
   gem 'fauxhai'
 end
 

recipes/default.rb

@@ -184,6 +184,14 @@ class Chef::Resource # rubocop:disable all
   notifies :restart, "service[#{node['rabbitmq']['service_name']}]", :immediately
 end
 
+template "/etc/default/#{node['rabbitmq']['service_name']}" do
+  source 'default.rabbitmq-server.erb'
+  owner 'root'
+  group 'root'
+  mode 00644
+  notifies :restart, "service[#{node['rabbitmq']['service_name']}]", :immediately
+end
+
 if File.exist?(node['rabbitmq']['erlang_cookie_path']) && File.readable?((node['rabbitmq']['erlang_cookie_path']))
   existing_erlang_key =  File.read(node['rabbitmq']['erlang_cookie_path']).strip
 else

spec/default_spec.rb

@@ -47,6 +47,15 @@
     expect(chef_run).to install_package('erlang')
   end
 
+  it 'should create the rabbitmq /etc/default file' do
+    expect(chef_run).to create_template("/etc/default/#{chef_run.node['rabbitmq']['service_name']}").with(
+      :user => 'root',
+      :group => 'root',
+      :source => 'default.rabbitmq-server.erb',
+      :mode => 00644
+    )
+  end
+
   describe 'suse' do
     let(:runner) { ChefSpec::ServerRunner.new(SUSE_OPTS) }
     let(:node) { runner.node }

templates/default/default.rabbitmq-server.erb

@@ -0,0 +1,14 @@
+###
+# Generated by Chef
+###
+
+# This file is sourced by /etc/init.d/rabbitmq-server. Its primary
+# reason for existing is to allow adjustment of system limits for the
+# rabbitmq-server process.
+#
+# Maximum number of open file handles. This will need to be increased
+# to handle many simultaneous connections. Refer to the system
+# documentation for ulimit (in man bash) for more information.
+#
+#ulimit -n 1024
+<% if node['rabbitmq']['open_file_limit'] -%>ulimit -n <%= node['rabbitmq']['open_file_limit'] %><% end %>

templates/default/rabbitmq-env.conf.erb

@@ -18,5 +18,3 @@ export ERL_EPMD_ADDRESS=<%= node['rabbitmq']['erl_networking_bind_address'] %>
 <% if node['rabbitmq']['config'] -%>CONFIG_FILE=<%= node['rabbitmq']['config'] %><% end %>
 <% if node['rabbitmq']['logdir'] -%>LOG_BASE=<%= node['rabbitmq']['logdir'] %><% end %>
 <% if node['rabbitmq']['mnesiadir'] -%>MNESIA_BASE=<%= node['rabbitmq']['mnesiadir'] %><% end %>
-
-<% if node['rabbitmq']['open_file_limit'] -%>ulimit -n <%= node['rabbitmq']['open_file_limit'] %><% end %>

test/cookbooks/rabbitmq_test/files/default/tests/minitest/cook-openfiles_test.rb

@@ -0,0 +1,24 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require File.expand_path('../support/helpers', __FILE__)
+
+describe 'rabbitmq_test::cook-openfiles' do
+  include Helpers::RabbitMQ
+
+  it 'properly sets open_file_limit' do
+    if node['rabbitmq']['open_file_limit']
+      command("grep 'Max open files' /proc/$(sudo pgrep -u rabbitmq beam)/limits | awk '{print $5}'").stdout.chomp == "#{node['rabbitmq']['open_file_limit']}"
+    end
+  end
+end

test/cookbooks/rabbitmq_test/recipes/cook-openfiles.rb

@@ -0,0 +1,26 @@
+#
+# Cookbook Name:: rabbitmq_test
+# Recipe:: cook-openfiles
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+node.set['rabbitmq']['open_file_limit'] = 2048
+include_recipe 'rabbitmq::default'
+
+# HACK: Give rabbit time to spin up before the tests, it seems
+# # to be responding that it has started before it really has
+execute 'sleep 10' do
+  action :nothing
+  subscribes :run, "service[#{node['rabbitmq']['service_name']}]", :delayed
+end