allow set_parameter changes to existing parameters #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in this way prevents updates
|
@stevenolen |
|
certainly! I brought it up as the chef resource itself isn't idempotent (eg. in this situation, the resource reports as "updated" to chef-client on each run). Obviously not a big deal, but definitely something to note! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply the same functionality as #425, but to parameters.
Since the actual chef resources themselves here are not actually idempotent, it is probably better to actually have a chef guard parse the
list_parameteroutput, but sinceset_policyis already being done in this manner, I figured it was acceptable functionality for now.