Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow set_parameter changes to existing parameters #439

Merged

Conversation

Projects
None yet
2 participants
@stevenolen
Copy link
Contributor

commented Apr 26, 2017

apply the same functionality as #425, but to parameters.

Since the actual chef resources themselves here are not actually idempotent, it is probably better to actually have a chef guard parse the list_parameter output, but since set_policy is already being done in this manner, I figured it was acceptable functionality for now.

set_parameter is already idempotent, and blocking
in this way prevents updates

@michaelklishin michaelklishin merged commit 93e51e3 into rabbitmq:master Apr 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

@stevenolen rabbitmqctl set_parameter is idempotent, though. Thank you.

@stevenolen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

certainly! I brought it up as the chef resource itself isn't idempotent (eg. in this situation, the resource reports as "updated" to chef-client on each run). Obviously not a big deal, but definitely something to note!

@stevenolen stevenolen deleted the rstudio:bugfix-set-parameter-updates branch Apr 26, 2017

@stevenolen stevenolen restored the rstudio:bugfix-set-parameter-updates branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.