Skip to content

Commit

Permalink
Remove unnecessary requeue
Browse files Browse the repository at this point in the history
- if no error was returned after defaulting, the
controller can move on to reconcile the object, there
is no need to requeue the request again
  • Loading branch information
ChunyiLyu committed Sep 30, 2020
1 parent f064344 commit 00b5c53
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions controllers/rabbitmqcluster_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ func (r *RabbitmqClusterReconciler) Reconcile(req ctrl.Request) (ctrl.Result, er
if err := r.Client.Update(ctx, rabbitmqCluster); err != nil {
return ctrl.Result{}, err
}
// TODO do we need to requeue?
return ctrl.Result{Requeue: true}, nil
}

// Resource has been marked for deletion
Expand Down

0 comments on commit 00b5c53

Please sign in to comment.