Minor bash improvements suggested by shellcheck.

rabbitmq · Mar 17, 2021 · eacf2fc · eacf2fc
1 parent b6a0068
commit eacf2fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/hack/add-notice-to-yaml.sh b/hack/add-notice-to-yaml.sh
@@ -3,7 +3,7 @@
 set -e
 
 TARGET_YAML=$1
-SCRIPT_DIR="$(dirname $0)"
+SCRIPT_DIR="$(dirname "$0")"
 
 if [[ -z $TARGET_YAML ]]
 then

diff --git a/hack/generate-ordered-api-reference-list.sh b/hack/generate-ordered-api-reference-list.sh
@@ -18,15 +18,15 @@ tail='^<!--- END API REFERENCE LIST -->$'
 unorderedlistfile="$(mktemp)"
 orderedlistfile="$(mktemp)"
 
-apiVersions="$(find $wikiDir/API_Reference_* -printf "%f\n" | sed -r 's/API_Reference_(v[0-9]+.[0-9]+.[0-9]+).asciidoc/\1/' | sort -Vr )"
+apiVersions="$(find "$wikiDir/API_Reference_*" -printf "%f\n" | sed -r 's/API_Reference_(v[0-9]+.[0-9]+.[0-9]+).asciidoc/\1/' | sort -Vr )"
 for version in $apiVersions
 do
-  echo "$(generateVersionedEntry $version)" >> $unorderedlistfile
+  generateVersionedEntry "$version" >> "$unorderedlistfile"
 done
 
 # Latest API version is a special case, that is always top of the list
-generateLatestEntry > $orderedlistfile
-cat $unorderedlistfile >> $orderedlistfile
+generateLatestEntry > "$orderedlistfile"
+cat "$unorderedlistfile" >> "$orderedlistfile"
 
 sed -e "/$lead/,/$tail/{ /$lead/{p; r $orderedlistfile
 }; /$tail/p; d }"  "$wikiDir/Wiki_Sidebar.md"