Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StatefulSet.Spec.PersistentVolumeClaimRetentionPolicy Override. #1237

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

MirahImage
Copy link
Member

This closes #1231

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Adds persistentVolumeClaimRetentionPolicy to the StatefulSet.Spec override.

@MirahImage MirahImage merged commit 7d3398f into main Jan 23, 2023
@MirahImage MirahImage deleted the pvc-retention-policy-override branch January 23, 2023 12:37
@Dragane
Copy link

Dragane commented Jan 24, 2023

Thank you so much for working on this solution Mirah.

I would like to point out the bug (typo) in the CRDS file config/crd/bases/rabbitmq.com_rabbitmqclusters.yaml

There is a letter t missing:
persistenVolumeClaimRetentionPolicy instead of persistentVolumeClaimRetentionPolicy

@MirahImage
Copy link
Member Author

Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow persistentVolumeClaimRetentionPolicy setting for RabbitMQ cluster statefulSet
3 participants