Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-queue-dashboard: fixed an issue with the usage of the datasource, added meaningful Legends and refresh to 10s #1302

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

sherifkayad
Copy link
Contributor

@sherifkayad sherifkayad commented Mar 27, 2023

rabbitmq-queue-dashboard: fixed an issue with the usage of the datasource, added meaningful Legends and refresh to 10s

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

rabbitmq-queue-dashboard:

  • fixed an issue with the usage of the datasource
  • added meaningful Legends
  • added refresh to 10s

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

…urce, added meaningful Legends and refresh to 10s

Signed-off-by: Sherif Ayad <sherif.k.ayad@gmail.com>
@sherifkayad
Copy link
Contributor Author

@DanielePalaia can you please have a look at that one as well? 😉 thanks in advance

@DanielePalaia
Copy link
Contributor

Hi @sherifkayad Thank you for the PR. Just to help us on the review, could you explain what issue you are experimenting with this dashboard and what improvements are you bring in? (Maybe also opening an issue and link it to this PR would be nice, and why not posting the grafana images if possibile).

@sherifkayad
Copy link
Contributor Author

@DanielePalaia The issue I had was if one would have a Prometheus DS not with the name Prometheus then this Dashboard would break; so I fixed that.

In addition, I added some legends to the Graph such that one could understand which value (bar) is the messages and which is the consumers.

My bad I didn't add some screenshots .. There you go.

Screenshot 2023-03-30 170525

@Zerpet Zerpet self-assigned this Apr 26, 2023
@Zerpet
Copy link
Collaborator

Zerpet commented Apr 27, 2023

Tried out the changes in this PR. This is the before:

Screenshot 2023-04-27 at 17 07 47

And after:

Screenshot 2023-04-27 at 17 17 31

Copy link
Collaborator

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Zerpet Zerpet merged commit ad59bc7 into rabbitmq:main Apr 27, 2023
@sherifkayad sherifkayad deleted the fixed-rabbitmq-queue-dashboard branch April 27, 2023 16:59
@sherifkayad
Copy link
Contributor Author

@Zerpet thanks for the feedback .. glad to be able to contribute something to this awesome repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants