Update Grafana dashboards #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grafana.com is rejecting HTTP requests with basic authentication. Earlier, it used to ignore the basic auth, and simply serve the request. This new behaviour in Grafana API breaks the sidecar import feature of Grafana's Helm Chart. The sidecar from Grafana uses basic authentication in their HTTP request. It then gets a not-authorized response from Grafana API, and dashboard importing fails. GitHub raw URLs ignore the basic auth and simply serve the file as a static element. Related to #1334 Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1334
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Use a perma-link to Grafana Dashboards in rabbitmq-server repo.
Additional Context
Grafana.comis rejecting HTTP requests with basic authentication. Earlier, it used to ignore the basic auth, and simply serve the request. This new behaviour in Grafana API breaks the sidecar import feature of Grafana's Helm Chart. The sidecar from Grafana uses basic authentication in their HTTP request. It then gets a not-authorized response from Grafana API, and dashboard importing fails.GitHub raw URLs ignore the basic auth and simply serve the file as a static element.
Local Testing
N/A - no code changes
Edit: formatting