Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply same code format for all resources #427

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Apply same code format for all resources #427

merged 1 commit into from
Oct 28, 2020

Conversation

ansd
Copy link
Member

@ansd ansd commented Oct 28, 2020

This is a simple copy and paste (no change of functionality) such that all resources have the same
code format in the form of:

type Builder struct {...}
NewBuilder() *Builder
Build()
Update()
private methods

to easier navigate the resources.

@ansd
Apply same code format for all resources
cc96594 
This commit is a simple copy and paste such that all resources have the same
code format in the form of:

type Builder struct
Build()
Update()
private methods
ChunyiLyu
ChunyiLyu approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@ansd ansd merged commit 6fc47e6 into main Oct 28, 2020
@ansd ansd deleted the format-resources branch October 28, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet approved these changes

@ChunyiLyu ChunyiLyu ChunyiLyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansd @Zerpet @ChunyiLyu