Remove duplicated name prefix #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name prefix is already present in the manager (operator) kustomization. Adding it here would produce doubly prefixed names e.g. rabbitmq-cluster-rabbitmq-cluster-operator
Zerpet
added this to Review in progress
in RabbitMQ Cluster Kubernetes Operator
via automation
ChunyiLyu
approved these changes
Oct 30, 2020
ansd
approved these changes
Nov 2, 2020
RabbitMQ Cluster Kubernetes Operator
automation
moved this from Review in progress
to Done
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Removed name prefix in the base kustomization file because the name prefix is already present in the manager kustomization.
Adding the name prefix here is producing double prefixed name for the Operator deployment e.g. rabbitmq-cluster-rabbitmq-cluster-operator.