Use RabbitMQ management image variant #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-managemet variant disabled metric collection in RabbitMQ configuration and it's not straightforward to re-enable them. The managmenet image does not disable these metrics and we want to always enable the management UI.
Zerpet
added this to Review in progress
in RabbitMQ Cluster Kubernetes Operator
via automation
ChunyiLyu
approved these changes
Nov 3, 2020
ansd
approved these changes
Nov 3, 2020
|
No need to squash IMO. One commit for default image change, another for helm chart. |
|
Two approvals, checks are green. Merging! 🚀 |
RabbitMQ Cluster Kubernetes Operator
automation
moved this from Review in progress
to Done
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #441
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
3.8.9-managementAdditional Context
The non-management image variant disables metrics collection by the management agent, resulting in very little information
shown in the management UI. We want to always enable the management UI as it is a common entry point to RabbitMQ
administration. It's also not straightforward to re-enable the metric collection in the non-management variant.
Local Testing