Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename #447

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Rename #447

merged 3 commits into from
Nov 6, 2020

Conversation

ChunyiLyu
Copy link
Contributor

This closes #415

It's a duplicate of #431, re created this branch because of the messy history

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • Rename the suffix "-headless" for the headless svc to -nodes since the suffix is unnecessary and exposes implementation details to users
  • Drop "rabbitmq" from child resources suffix. We are already labelling all resources with the CR name - and the component name was rabbitmq. This suffix seems rather redundant
  • Drop the suffix -client for the external rmq svc. Also rename client_service.go to service.go, since I find it confusing. override.clientService is renamed to override.service as well.

Additional Context

Local Testing

Have run unit, integration, and system tests

@ChunyiLyu
Remove 'rabbitmq' from child resources suffix
def80cc 
- less redundant and shorter resource names
@ChunyiLyu
Rename headless svc suffix to "nodes"
bc8bc2f
@ChunyiLyu
Drop '-client' suffix from rmq service
b5d7713 
- rename ClientService override to Service override
- rename client_service.go to service.go
@ChunyiLyu ChunyiLyu requested review from ansd and mkuratczyk and removed request for ansd November 6, 2020 14:49
@ChunyiLyu ChunyiLyu mentioned this pull request Nov 6, 2020
Closed
mkuratczyk
mkuratczyk approved these changes Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@mkuratczyk mkuratczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@ChunyiLyu ChunyiLyu merged commit dda2be1 into main Nov 6, 2020
@ChunyiLyu ChunyiLyu deleted the rename branch November 6, 2020 15:38
ansd added a commit that referenced this pull request Nov 6, 2020
@ansd
Rebase onto origin/main
f1d3e64 
Fix failing tests due to changes in #447
ansd added a commit that referenced this pull request Nov 6, 2020
@ansd
Add tests for kubectl plugin (#445)
db113e5 
* Add tests for kubectl-rabbitmq

See #440

* Test rabbitmq plugin in GitHub actions

See #440

* Rebase onto origin/main

Fix failing tests due to changes in #447
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuratczyk mkuratczyk mkuratczyk approved these changes

@ansd ansd ansd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop "headless" from the service name
3 participants
@ChunyiLyu @mkuratczyk @ansd