Stop triggering pod restarts for CR labels/annotations updates #449
+183
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we don't want to trigger pod restarts for CR labels/annotations updates
- updates to server-conf configMap triggers pod restart - instance labels and annotations are still applied at creation
mkuratczyk
approved these changes
Nov 9, 2020
ansd
reviewed
Nov 9, 2020
- this is to avoid running `rabbitmq-plugins set` everytime the CR annotations and labels are updated. - CR annotations and labels are still applied to plugins configmap at creation.
ChunyiLyu
force-pushed
the
label-annotation-inheritance
branch
from
f4c3945
to
06a5c83
Compare
ansd
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #442
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Stop updating label/annotation on plugins configmap, because updates to the plugins configMap triggers unnecessary
rabbitmq-plugins set.Additional Context
Local Testing
Have run unit, integration, and system tests.