Fail to set plugins (or any other necessary cli commands) should result in ReconcileSuccess set to false #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ReconcileSuccess was set to true when set plugins command failed - ReconcileSuccess will only be set to true if all necessary commands (set plugins, feature flags, rebalance) are run successfullly
Zerpet
approved these changes
Feb 10, 2021
- also adds msg to returned errors since error will be used as ReconcileSuccess status condition messages
ChunyiLyu
force-pushed
the
failed-set-plugins
branch
from
64d1608
to
cb758b9
Compare
MirahImage
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
When
Reconcilie()fails to set plugins, feature flags, or rebalance when necessary:failedReconcilewarning eventsReconcileSuccessto falseAdditional Context
Removed an integration test because pods are never successfully created in envTest and plugins cannot be successfully set, so
ReconcileSuccesscan never be set to true in integration tests.Local Testing
All tests passing locally