Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused status.clusterStatus #646

Merged
merged 1 commit into from Mar 26, 2021
Merged

Remove unused status.clusterStatus #646

merged 1 commit into from Mar 26, 2021

Conversation

ChunyiLyu
Copy link
Contributor

This closes #636

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • remove unused rabbitmqCluster.status.clusterStatus from cluster status

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Copy link
Collaborator

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest, as part of this PR, replace (instead of remove) cluster status with some other print columns?

I was thinking of exposing perhaps AllReplicasReady and ReconcileSuccess?

I think that if we just remove, out kubectl get rmq output won't provide much information. I'm ok too if you want to implement the printing columns as part of another story/PR.

Last thing, perhaps is time to do a go mod tidy? We have some dependencies declared 3 or 4 times 🙈

docs/api/rabbitmq.com.ref.asciidoc Outdated Show resolved Hide resolved
@ChunyiLyu
Copy link
Contributor Author

@Zerpet status.clusterStatus is empty and not set. If you list rabbitmqCluster now (without this change), it looks like

NAME     AGE   STATUS
sample   3s

Deleting status.clusterStatus is not removing any currently available information from our users. We can certainly print additional information in in the column, but sounds like a different PR to me.

Copy link
Collaborator

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create an issue to add additional printing columns 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused rabbitmqCluster.status.clusterStatus
3 participants