forked from ninenines/cowboy
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Cleanup #1
Open
spring-operator
wants to merge
1
commit into
rabbitmq:master
Choose a base branch
from
spring-operator:polish-urls-remaining-master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
URL Cleanup #1
spring-operator
wants to merge
1
commit into
rabbitmq:master
from
spring-operator:polish-urls-remaining-master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * http://blog.listincomprehension.com/search/label/procket (200) with 1 occurrences could not be migrated: ([https](https://blog.listincomprehension.com/search/label/procket) result ClosedChannelException). * http://e2project.org (200) with 1 occurrences could not be migrated: ([https](https://e2project.org) result AnnotatedConnectException). * http://gossiperl.com/ (200) with 1 occurrences could not be migrated: ([https](https://gossiperl.com/) result SSLHandshakeException). * http://nitrogenproject.com/ (200) with 2 occurrences could not be migrated: ([https](https://nitrogenproject.com/) result ConnectTimeoutException). * http://proper.softlab.ntua.gr (200) with 1 occurrences could not be migrated: ([https](https://proper.softlab.ntua.gr) result SSLHandshakeException). * http://yaws.hyber.org (200) with 1 occurrences could not be migrated: ([https](https://yaws.hyber.org) result AnnotatedConnectException). * http://techslides.com/sample-webm-ogg-and-mp4-video-files-for-html5/ (301) with 2 occurrences could not be migrated: ([https](https://techslides.com/sample-webm-ogg-and-mp4-video-files-for-html5/) result AnnotatedConnectException). * http://www.andre-simon.de/doku/highlight/en/highlight.html (301) with 1 occurrences could not be migrated: ([https](https://www.andre-simon.de/doku/highlight/en/highlight.html) result SSLHandshakeException). * http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd (404) with 8 occurrences could not be migrated: ([https](https://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd) result AnnotatedConnectException). * http://choven.ca (503) with 1 occurrences could not be migrated: ([https](https://choven.ca) result ConnectTimeoutException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * http://autobahn.ws/testsuite/installation.html (301) with 1 occurrences migrated to: https://crossbar.io/autobahn/testsuite/installation.html ([https](https://autobahn.ws/testsuite/installation.html) result AnnotatedConnectException). * http://fixprotocol.org/ (301) with 1 occurrences migrated to: https://fixtrading.org ([https](https://fixprotocol.org/) result SSLHandshakeException). * http://LoCaLHOsT/echo/url (AnnotatedConnectException) with 1 occurrences migrated to: https://LoCaLHOsT/echo/url ([https](https://LoCaLHOsT/echo/url) result AnnotatedConnectException). * http://example.org:8080/echo/host (ConnectTimeoutException) with 1 occurrences migrated to: https://example.org:8080/echo/host ([https](https://example.org:8080/echo/host) result ConnectTimeoutException). * http://example.org:8080/echo/port (ConnectTimeoutException) with 1 occurrences migrated to: https://example.org:8080/echo/port ([https](https://example.org:8080/echo/port) result ConnectTimeoutException). * http://example.org:8080/path?dummy=2785 (ConnectTimeoutException) with 1 occurrences migrated to: https://example.org:8080/path?dummy=2785 ([https](https://example.org:8080/path?dummy=2785) result ConnectTimeoutException). * http:/// (UnknownHostException) with 1 occurrences migrated to: https:/// ([https](https:///) result UnknownHostException). * http://erldb.org (UnknownHostException) with 1 occurrences migrated to: https://erldb.org ([https](https://erldb.org) result UnknownHostException). * http://proxy/ (UnknownHostException) with 2 occurrences migrated to: https://proxy/ ([https](https://proxy/) result UnknownHostException). * http://username:password@localhost (UnknownHostException) with 1 occurrences migrated to: https://username:password@localhost ([https](https://username:password@localhost) result UnknownHostException). * http://www.openswatchbook.org/uri/2009/osb (UnknownHostException) with 8 occurrences migrated to: https://www.openswatchbook.org/uri/2009/osb ([https](https://www.openswatchbook.org/uri/2009/osb) result UnknownHostException). * http://example.org/echo/host (404) with 1 occurrences migrated to: https://example.org/echo/host ([https](https://example.org/echo/host) result 404). * http://example.org/path/to/res?edit=1 (404) with 2 occurrences migrated to: https://example.org/path/to/res?edit=1 ([https](https://example.org/path/to/res?edit=1) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://cloudi.org/ with 27 occurrences migrated to: https://cloudi.org/ ([https](https://cloudi.org/) result 200). * http://creativecommons.org/ns with 8 occurrences migrated to: https://creativecommons.org/ns ([https](https://creativecommons.org/ns) result 200). * http://erlang.mk/guide/installation.html with 1 occurrences migrated to: https://erlang.mk/guide/installation.html ([https](https://erlang.mk/guide/installation.html) result 200). * http://erlware.org/ with 1 occurrences migrated to: https://erlware.org/ ([https](https://erlware.org/) result 200). * http://example.org with 1 occurrences migrated to: https://example.org ([https](https://example.org) result 200). * http://inaka.github.io/cowboy-trails/ with 1 occurrences migrated to: https://inaka.github.io/cowboy-trails/ ([https](https://inaka.github.io/cowboy-trails/) result 200). * http://learnyousomeerlang.com with 1 occurrences migrated to: https://learnyousomeerlang.com ([https](https://learnyousomeerlang.com) result 200). * http://ninenines.eu with 8 occurrences migrated to: https://ninenines.eu ([https](https://ninenines.eu) result 200). * http://ninenines.eu/docs/en/ranch/1.3/guide/listeners/ with 1 occurrences migrated to: https://ninenines.eu/docs/en/ranch/1.3/guide/listeners/ ([https](https://ninenines.eu/docs/en/ranch/1.3/guide/listeners/) result 200). * http://pragprog.com/book/jaerlang2/programming-erlang with 1 occurrences migrated to: https://pragprog.com/book/jaerlang2/programming-erlang ([https](https://pragprog.com/book/jaerlang2/programming-erlang) result 200). * http://semver.org/ with 1 occurrences migrated to: https://semver.org/ ([https](https://semver.org/) result 200). * http://www.actordb.com/ with 2 occurrences migrated to: https://www.actordb.com/ ([https](https://www.actordb.com/) result 200). * http://www.cs.kent.ac.uk/projects/wrangler/Home.html with 1 occurrences migrated to: https://www.cs.kent.ac.uk/projects/wrangler/Home.html ([https](https://www.cs.kent.ac.uk/projects/wrangler/Home.html) result 200). * http://www.google.co.il/ with 2 occurrences migrated to: https://www.google.co.il/ ([https](https://www.google.co.il/) result 200). * http://www.ics.uci.edu/~fielding/pubs/dissertation/top.htm with 1 occurrences migrated to: https://www.ics.uci.edu/~fielding/pubs/dissertation/top.htm ([https](https://www.ics.uci.edu/~fielding/pubs/dissertation/top.htm) result 200). * http://www.rebar3.org with 1 occurrences migrated to: https://www.rebar3.org ([https](https://www.rebar3.org) result 200). * http://www.w3.org/1999/02/22-rdf-syntax-ns with 8 occurrences migrated to: https://www.w3.org/1999/02/22-rdf-syntax-ns ([https](https://www.w3.org/1999/02/22-rdf-syntax-ns) result 200). * http://inaka.github.com/apns4erl with 1 occurrences migrated to: https://inaka.github.com/apns4erl ([https](https://inaka.github.com/apns4erl) result 301). * http://inaka.github.com/edis/ with 1 occurrences migrated to: https://inaka.github.com/edis/ ([https](https://inaka.github.com/edis/) result 301). * http://lasp-lang.org/ with 1 occurrences migrated to: https://lasp-lang.org/ ([https](https://lasp-lang.org/) result 301). * http://ninenines.eu/docs/en/cowboy/2.0/guide with 1 occurrences migrated to: https://ninenines.eu/docs/en/cowboy/2.0/guide ([https](https://ninenines.eu/docs/en/cowboy/2.0/guide) result 301). * http://ninenines.eu/docs/en/cowboy/2.0/manual with 1 occurrences migrated to: https://ninenines.eu/docs/en/cowboy/2.0/manual ([https](https://ninenines.eu/docs/en/cowboy/2.0/manual) result 301). * http://ninenines.eu/services with 1 occurrences migrated to: https://ninenines.eu/services ([https](https://ninenines.eu/services) result 301). * http://saleyn.github.com/erlexec with 1 occurrences migrated to: https://saleyn.github.com/erlexec ([https](https://saleyn.github.com/erlexec) result 301). * http://www.inkscape.org/ with 8 occurrences migrated to: https://www.inkscape.org/ ([https](https://www.inkscape.org/) result 301). * http://www.inkscape.org/namespaces/inkscape with 8 occurrences migrated to: https://www.inkscape.org/namespaces/inkscape ([https](https://www.inkscape.org/namespaces/inkscape) result 301). * http://purl.org/dc/dcmitype/StillImage with 8 occurrences migrated to: https://purl.org/dc/dcmitype/StillImage ([https](https://purl.org/dc/dcmitype/StillImage) result 302). # Ignored These URLs were intentionally ignored. * http://127.0.0.1/echo/host with 1 occurrences * http://127.0.0.1:8080/echo/host with 1 occurrences * http://127.0.0.1:8080/echo/port with 1 occurrences * http://localhost with 7 occurrences * http://localhost/echo/path with 2 occurrences * http://localhost/echo/path?key=value with 1 occurrences * http://localhost/echo/qs?key=value with 2 occurrences * http://localhost/echo/url with 5 occurrences * http://localhost/echo/url?key=value with 1 occurrences * http://localhost/path with 1 occurrences * http://localhost/path?dummy=2785 with 2 occurrences * http://localhost:0/ with 1 occurrences * http://localhost:123/path?dummy=2785 with 1 occurrences * http://localhost:443/path with 1 occurrences * http://localhost:65536/ with 1 occurrences * http://localhost:8080 with 41 occurrences * http://localhost:8080/?echo=hello with 1 occurrences * http://localhost:8080/?echo=saymyname with 2 occurrences * http://localhost:8080/custom?dummy=2785 with 1 occurrences * http://localhost:8080/path with 5 occurrences * http://localhost:8080/path?dummy=2785 with 7 occurrences * http://localhost:8080/path?smart=42 with 1 occurrences * http://localhost:8080/test with 1 occurrences * http://localhost:8080/test.txt with 3 occurrences * http://localhost:8080/video.html with 2 occurrences * http://localhost:8080?dummy=2785 with 4 occurrences * http://localhost?key=value with 1 occurrences * http://purl.org/dc/elements/1.1/ with 8 occurrences * http://test.example.org/hats/wild_cowboy_legendary/prices with 1 occurrences * http://www.w3.org/1999/xlink with 8 occurrences * http://www.w3.org/2000/svg with 16 occurrences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
HTTP URLs that Could Not Be Fixed
These URLs were unable to be fixed. Please review them to see if they can be manually resolved.
(https result ClosedChannelException).
(https result AnnotatedConnectException).
(https result SSLHandshakeException).
(https result ConnectTimeoutException).
(https result SSLHandshakeException).
(https result AnnotatedConnectException).
(https result AnnotatedConnectException).
(https result SSLHandshakeException).
(https result AnnotatedConnectException).
(https result ConnectTimeoutException).
Fixed URLs
Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.
https://crossbar.io/autobahn/testsuite/installation.html (https result AnnotatedConnectException).
https://fixtrading.org (https result SSLHandshakeException).
https://LoCaLHOsT/echo/url (https result AnnotatedConnectException).
https://example.org:8080/echo/host (https result ConnectTimeoutException).
https://example.org:8080/echo/port (https result ConnectTimeoutException).
https://example.org:8080/path?dummy=2785 (https result ConnectTimeoutException).
https:/// (https result UnknownHostException).
https://erldb.org (https result UnknownHostException).
https://proxy/ (https result UnknownHostException).
https://username:password@localhost (https result UnknownHostException).
https://www.openswatchbook.org/uri/2009/osb (https result UnknownHostException).
https://example.org/echo/host (https result 404).
https://example.org/path/to/res?edit=1 (https result 404).
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
https://cloudi.org/ (https result 200).
https://creativecommons.org/ns (https result 200).
https://erlang.mk/guide/installation.html (https result 200).
https://erlware.org/ (https result 200).
https://example.org (https result 200).
https://inaka.github.io/cowboy-trails/ (https result 200).
https://learnyousomeerlang.com (https result 200).
https://ninenines.eu (https result 200).
https://ninenines.eu/docs/en/ranch/1.3/guide/listeners/ (https result 200).
https://pragprog.com/book/jaerlang2/programming-erlang (https result 200).
https://semver.org/ (https result 200).
https://www.actordb.com/ (https result 200).
https://www.cs.kent.ac.uk/projects/wrangler/Home.html (https result 200).
https://www.google.co.il/ (https result 200).
https://www.ics.uci.edu/~fielding/pubs/dissertation/top.htm (https result 200).
https://www.rebar3.org (https result 200).
https://www.w3.org/1999/02/22-rdf-syntax-ns (https result 200).
https://inaka.github.com/apns4erl (https result 301).
https://inaka.github.com/edis/ (https result 301).
https://lasp-lang.org/ (https result 301).
https://ninenines.eu/docs/en/cowboy/2.0/guide (https result 301).
https://ninenines.eu/docs/en/cowboy/2.0/manual (https result 301).
https://ninenines.eu/services (https result 301).
https://saleyn.github.com/erlexec (https result 301).
https://www.inkscape.org/ (https result 301).
https://www.inkscape.org/namespaces/inkscape (https result 301).
https://purl.org/dc/dcmitype/StillImage (https result 302).
Ignored
These URLs were intentionally ignored.