horus.app: Add erts to application dependencies
#15
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] Horus relies on the availability of `erts` to initialize the list of modules to skip when it needs to decide if a call should be followed to extract a function or if the call should be preserved as is. It already depends on `kernel` and `stdlib` for instance. I assumed that `erts` was implicit as I don't see how Erlang can work without it. It looks like if `erts` is not included explicitly in an Erlang release file or in the applications it bundles, it is excluded from the release (the `erts` Erlang application, not the actual runtime). This breaks Horus because it won't know about e.g. the `erlang` module and will try and fail to extract functions from that module. Fixes #14.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 3 3
Lines 918 918
=======================================
Hits 790 790
Misses 128 128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Horus relies on the availability of
ertsto initialize the list of modules to skip when it needs to decide if a call should be followed to extract a function or if the call should be preserved as is.It already depends on
kernelandstdlibfor instance. I assumed thatertswas implicit as I don't see how Erlang can work without it. It looks like ifertsis not included explicitly in an Erlang release file or in the applications it bundles, it is excluded from the release (theertsErlang application, not the actual runtime). This breaks Horus because it won't know about e.g. theerlangmodule and will try and fail to extract functions from that module.Fixes #14.