Automatically reclaim useless tree nodes created automatically #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
auto-reclaim-useless-tree-nodes
branch
from
c3d2256
to
52ecfb8
Compare
Codecov ReportBase: 90.98% // Head: 90.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 90.98% 90.97% -0.02%
==========================================
Files 16 16
Lines 2951 2958 +7
==========================================
+ Hits 2685 2691 +6
- Misses 266 267 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dumbbell
force-pushed
the
auto-reclaim-useless-tree-nodes
branch
from
52ecfb8
to
c4a1065
Compare
the-mikedavis
approved these changes
Oct 21, 2022
dcorbacho
approved these changes
Oct 24, 2022
This variable is used for triggers as well, so a more generic name, not something keep_while-conditions-specific, makes more sense.
This makes naming more consistent.
Also, this fixes an incorrect set of `#{Watcher => remove}`. It will
never match anything and would probably crash. It means the testsuite
does not cover this code path...
... instead of `specific_node` or `many_nodes`. This allows to access the value of `include_root_props` without having to add it to `Extra`. Doing this broke the type spec but Dialyzer didn't notice it.
`none` is not a valid value. To specify "return no props", the option should be set to an empty map.
This is the same as `#if_has_data{}` but for any kind of payload. I.e.
`#if_has_payload{}` will be true if a tree node hold a stored procedure.
`#if_has_data{}` would have been false for that same tree node.
This is the same as `#if_has_data{}` but for stored procedures.
We now have a more consistent set of `#if_has_*{}` conditions. Thank you
@the-mikedavis for pointing out the issue.
…matically For instance, if a caller stores a value in "/:stock/:wood/oak", both `stock` and `wood` tree nodes are created on the fly, with no payload attached to them. Now, for these automatically created nodes, a "keep while" condition is added so that they are automatically reclaimed as soon as they have no child nodes and no payload. In this example, if "/:stock/:wood/oak" is deleted and no other tree nodes were added below "/:stock" or "/:stock/:wood", both `stock` and `wood` will be deleted as well. Fixes #140.
dumbbell
force-pushed
the
auto-reclaim-useless-tree-nodes
branch
from
c4a1065
to
caa77f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, if a caller stores a value in
"/:stock/:wood/oak", bothstockandwoodtree nodes are created on the fly, with no payload attached to them.Now, for these automatically created nodes, a "keep while" condition is added so that they are automatically reclaimed as soon as they have no child nodes and no payload.
In this example, if
"/:stock/:wood/oak"is deleted and no other tree nodes were added below"/:stock"or"/:stock/:wood", bothstockandwoodwill be deleted as well.Fixes #140.