Support empty binaries in string-based paths #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FTR, we will use empty binaries in RabbitMQ. |
Codecov ReportBase: 90.80% // Head: 90.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 90.80% 90.97% +0.17%
==========================================
Files 16 16
Lines 2958 2971 +13
==========================================
+ Hits 2686 2703 +17
+ Misses 272 268 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
the-mikedavis
approved these changes
Oct 21, 2022
dumbbell
force-pushed
the
encode-empty-binary-in-path
branch
2 times, most recently
from
729ee56
to
c02bc40
Compare
This adds the ability to convert a path such as `[<<>>]` to a string (`"//"` in this case). URIs can have meaningful consecutive forward slashes. We use this to encode empty binaries in string-based paths. This is breaking change because consecutive forward slashes were ignored before. Here are a few examples: * `[<<>>]` = `"//"` * `[<<>>, <<>>]` = `"///"` * `[foo, <<>>, bar]` = `"/:foo//:bar"` * `[foo, bar, <<>>]` = `"/:foo/:bar//`
dumbbell
force-pushed
the
encode-empty-binary-in-path
branch
from
c02bc40
to
fbeb0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to convert a path such as
[<<>>]to a string ("//"in this case).URIs can have meaningful consecutive forward slashes. We use this to encode empty binaries in string-based paths. This is breaking change because consecutive forward slashes were ignored before.
Here are a few examples:
[<<>>]="//"[<<>>, <<>>]="///"[foo, <<>>, bar]="/:foo//:bar"[foo, bar, <<>>]="/:foo/:bar//