Implement ra_machine:overview/1 for khepri_machine #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overview callback formats the state of the machine for functions like `sys:get_status/1`. The actual state of the machine is still accessible with `sys:get_state/1`. The status output was not very readable because of the beam code binaries in `standalone_fun` records and the use of records for nodes in the internal representation of the tree. This `overview/1` implementation uses the map representation of the tree from `khepri_utils:flat_struct_to_tree/1` and converts compiled standalone functions into regular functions with `erlang:make_fun/3` (which are printed with a more concise and readable format).
Codecov ReportBase: 90.97% // Head: 91.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 90.97% 91.08% +0.10%
==========================================
Files 16 16
Lines 2971 2983 +12
==========================================
+ Hits 2703 2717 +14
+ Misses 268 266 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overview callback formats the state of the machine for functions like
sys:get_status/1. The actual state of the machine is still accessible withsys:get_state/1.The status output was not very readable because of the beam code binaries in
standalone_funrecords and the use of records for nodes in the internal representation of the tree. Thisoverview/1implementation uses the map representation of the tree fromkhepri_utils:flat_struct_to_tree/1and converts compiled standalone functions into regular functions witherlang:make_fun/3(which are printed with a more concise and readable format).