Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khepri_machine: Merge extra into options in #put{} command #166

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

dumbbell
Copy link
Member

@dumbbell dumbbell commented Nov 7, 2022

This removes one map from the command. This map would have been empty most of the time (about 6 bytes when converted to binary).

This removes one map from the command. This map would have been empty
most of the time (about 6 bytes when converted to binary).
@dumbbell dumbbell added the enhancement New feature or request label Nov 7, 2022
@dumbbell dumbbell added this to the v0.6.0 milestone Nov 7, 2022
@dumbbell dumbbell self-assigned this Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 90.96% // Head: 90.98% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5b5a74b) compared to base (eb31817).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   90.96%   90.98%   +0.01%     
==========================================
  Files          18       18              
  Lines        3156     3163       +7     
==========================================
+ Hits         2871     2878       +7     
  Misses        285      285              
Flag Coverage Δ
erlang-24 89.63% <100.00%> (+0.02%) ⬆️
erlang-25 89.66% <100.00%> (+0.08%) ⬆️
os-ubuntu-latest 90.92% <100.00%> (-0.05%) ⬇️
os-windows-latest 89.66% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/khepri_import_export.erl 95.29% <ø> (ø)
src/khepri_machine.erl 94.86% <100.00%> (+0.04%) ⬆️
src/khepri_tx_adv.erl 80.48% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dumbbell dumbbell marked this pull request as ready for review November 7, 2022 21:00
@dumbbell dumbbell merged commit 530af87 into main Nov 8, 2022
@dumbbell dumbbell deleted the merge-tree-options-and-extra-in-put-command branch November 8, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants