khepri_fun: Fix translation for bs_get_float2 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolution for `bs_get_float2` in `beam_disasm` is in the same
block and has the same body as the translations for `bs_get_integer2`
and `bs_get_binary2` so it has the same mistranslations and can be
fixed in the same way.
We can provoke a `{test,bs_get_float2,..}` instruction by pattern
matching on a bitstring that uses the `float` type specifier.
Codecov ReportBase: 90.67% // Head: 90.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 90.67% 90.76% +0.08%
==========================================
Files 19 19
Lines 3377 3377
==========================================
+ Hits 3062 3065 +3
+ Misses 315 312 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolution for
bs_get_float2inbeam_disasmis in the same block and has the same body as the translations forbs_get_integer2andbs_get_binary2so it has the same mistranslations and can be fixed in the same way.We can provoke a
{test,bs_get_float2,..}instruction by pattern matching on a bitstring that uses thefloattype specifier.